Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Marketplace): Subscription modal wrong state #32730

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Jul 5, 2024

CONN-285

Fixed issue in Marketplace that caused a subscription app to show incorrect modals when subscribing

Copy link

changeset-bot bot commented Jul 5, 2024

🦋 Changeset detected

Latest commit: 09c825a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Jul 5, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.72%. Comparing base (ee60ea6) to head (09c825a).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32730      +/-   ##
===========================================
+ Coverage    55.60%   55.72%   +0.11%     
===========================================
  Files         2637     2636       -1     
  Lines        57313    57274      -39     
  Branches     11869    11863       -6     
===========================================
+ Hits         31869    31916      +47     
+ Misses       22744    22639     -105     
- Partials      2700     2719      +19     
Flag Coverage Δ
e2e 54.35% <ø> (+0.02%) ⬆️
unit 72.36% <40.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review July 9, 2024 19:10
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner July 9, 2024 19:10
@MartinSchoeler MartinSchoeler added this to the 6.11 milestone Jul 12, 2024
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Jul 22, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 22, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jul 22, 2024
@casalsgh casalsgh added the stat: ready to merge PR tested and approved waiting for merge label Jul 23, 2024
@kodiakhq kodiakhq bot merged commit 9d0612a into develop Jul 23, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the fix-sub-apps branch July 23, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants