Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Mention @all @here flaky test #32731

Merged
merged 5 commits into from
Jul 9, 2024

Conversation

KevLehman
Copy link
Contributor

FLAKY-198

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jul 5, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 5, 2024

⚠️ No Changeset found

Latest commit: 7682892

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (2224150) to head (7682892).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32731      +/-   ##
===========================================
+ Coverage    50.82%   56.83%   +6.00%     
===========================================
  Files         1933     2498     +565     
  Lines        46542    55336    +8794     
  Branches      9419    11412    +1993     
===========================================
+ Hits         23656    31451    +7795     
- Misses       20754    21177     +423     
- Partials      2132     2708     +576     
Flag Coverage Δ
e2e 56.49% <ø> (+13.51%) ⬆️
unit 72.49% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review July 8, 2024 14:23
@KevLehman KevLehman requested a review from a team as a code owner July 8, 2024 14:23
@KevLehman KevLehman added stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge labels Jul 8, 2024
@kodiakhq kodiakhq bot merged commit 72b8b5e into develop Jul 9, 2024
48 checks passed
@kodiakhq kodiakhq bot deleted the fix/message-mentions-flaky-all-herre branch July 9, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants