fix: validate username before registering user #32743
Merged
+161
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: a56bc19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ricardogarim
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32743 +/- ##
========================================
Coverage 59.43% 59.43%
========================================
Files 2546 2547 +1
Lines 63257 63265 +8
Branches 14236 14237 +1
========================================
+ Hits 37596 37604 +8
Misses 22941 22941
Partials 2720 2720
Flags with carried forward coverage won't be shown. Click here to find out more. |
ricardogarim
force-pushed
the
fix/validate-username-on-users-register
branch
from
f8245ce
to
335e9b2
Compare
MarcosSpessatto
requested changes
Jul 10, 2024
There was a problem hiding this comment.
I think there are more places that require this change to be applied (or at least reviewed)...
https://github.com/RocketChat/Rocket.Chat/blob/develop/apps/meteor/server/methods/registerUser.ts#L31 is one of them, but I think we should revisit all the places where users are being created, like LDAP, SAML, admin panel, etc.
KevLehman
requested changes
Aug 16, 2024
apps/meteor/tests/unit/app/lib/server/functions/validateUsername.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/unit/app/lib/server/functions/validateUsername.spec.ts
Outdated
Show resolved
Hide resolved
KevLehman
reviewed
Aug 19, 2024
apps/meteor/tests/unit/app/lib/server/functions/validateUsername.spec.ts
Show resolved
Hide resolved
apps/meteor/tests/unit/app/lib/server/functions/validateUsername.spec.ts
Outdated
Show resolved
Hide resolved
KevLehman
approved these changes
Aug 20, 2024
MarcosSpessatto
approved these changes
Aug 21, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per CORE-544 and as discussed internally at #rocketchat-dev, creating a new user with an invalid username (containing special characters) results in an error message, but the user is still created. This leads to an error when attempting to register again using the same email, as it is already registered.
To address this issue, I introduced a new method to validate usernames before registering users, ensuring that invalid usernames prevent user creation.
Screen.Recording.2024-07-08.at.08.57.04.mov