Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sidebar scrolling misclick issue on iOS #32769

Merged
merged 4 commits into from
Jul 24, 2024
Merged

fix: Sidebar scrolling misclick issue on iOS #32769

merged 4 commits into from
Jul 24, 2024

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Jul 11, 2024

Proposed changes (including videos or screenshots)

An outdated polyfill was causing misclick issues when scrolling the channels sidebar

Issue(s)

Steps to test or reproduce

Further comments

SUP-582

Copy link
Contributor

dionisio-bot bot commented Jul 11, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 11, 2024

🦋 Changeset detected

Latest commit: 52b02c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MartinSchoeler MartinSchoeler changed the title fix: Sidebar Scrolling issue on iOS fix: Sidebar scrolling misclick issue on iOS Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.44%. Comparing base (05db8aa) to head (52b02c5).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32769      +/-   ##
===========================================
- Coverage    55.50%   55.44%   -0.07%     
===========================================
  Files         2637     2635       -2     
  Lines        57289    57270      -19     
  Branches     11859    11855       -4     
===========================================
- Hits         31797    31752      -45     
- Misses       22801    22828      +27     
+ Partials      2691     2690       -1     
Flag Coverage Δ
e2e 53.99% <50.00%> (-0.12%) ⬇️
unit 72.34% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review July 11, 2024 20:29
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner July 11, 2024 20:29
Copy link
Member

@yash-rajpal yash-rajpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the comment left.

yash-rajpal
yash-rajpal previously approved these changes Jul 12, 2024
@yash-rajpal yash-rajpal added this to the 6.11 milestone Jul 12, 2024
@scuciatto scuciatto removed this from the 6.11 milestone Jul 18, 2024
@MartinSchoeler MartinSchoeler marked this pull request as draft July 22, 2024 13:15
@MartinSchoeler
Copy link
Contributor Author

Putting this as draft since the issue seems more complex than initially estimated

Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix missing changeset

@dougfabris dougfabris added this to the 6.11 milestone Jul 22, 2024
@dougfabris dougfabris removed this from the 6.11 milestone Jul 22, 2024
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jul 23, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dougfabris dougfabris added this to the 6.11 milestone Jul 23, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 23, 2024
@dougfabris dougfabris removed the request for review from tassoevan July 23, 2024 18:42
@ggazzo ggazzo merged commit 553ce5e into develop Jul 24, 2024
49 checks passed
@ggazzo ggazzo deleted the fix-ios-polyfill branch July 24, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants