Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds snapshot tests in ui-video-conf package #32780

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

dougfabris
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jul 12, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 12, 2024

⚠️ No Changeset found

Latest commit: cffe4c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris changed the title chore: Adds snapshot tests in ui-videconf package chore: Adds snapshot tests in ui-video-conf package Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.98%. Comparing base (7515c17) to head (cffe4c9).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32780   +/-   ##
========================================
  Coverage    54.98%   54.98%           
========================================
  Files         2596     2596           
  Lines        55971    55971           
  Branches     11585    11585           
========================================
  Hits         30775    30775           
  Misses       22553    22553           
  Partials      2643     2643           
Flag Coverage Δ
unit 73.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review July 15, 2024 21:04
@dougfabris dougfabris requested a review from a team August 6, 2024 16:37
@tassoevan tassoevan merged commit c97b46e into develop Aug 7, 2024
49 checks passed
@tassoevan tassoevan deleted the chore/ui-videoconf-tests branch August 7, 2024 20:42
@dougfabris dougfabris added this to the 6.12 milestone Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants