fix: bad word filtering not working #32810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhinav Kumar <[email protected]>
Signed-off-by: Abhinav Kumar <[email protected]>
🦋 Changeset detectedLatest commit: 4cf9f4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32810 +/- ##
===========================================
- Coverage 55.54% 55.54% -0.01%
===========================================
Files 2634 2633 -1
Lines 57215 57184 -31
Branches 11849 11843 -6
===========================================
- Hits 31782 31762 -20
+ Misses 22742 22737 -5
+ Partials 2691 2685 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Abhinav Kumar <[email protected]>
Signed-off-by: Abhinav Kumar <[email protected]>
Gustrb
reviewed
Jul 17, 2024
Gustrb
reviewed
Jul 17, 2024
Gustrb
reviewed
Jul 17, 2024
Gustrb
reviewed
Jul 17, 2024
Signed-off-by: Abhinav Kumar <[email protected]>
Gustrb
approved these changes
Jul 17, 2024
KevLehman
approved these changes
Jul 17, 2024
MarcosSpessatto
approved these changes
Jul 18, 2024
csuadev
approved these changes
Jul 18, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fixes bad word filtering not working issue. If we look into the DB record, we'll see the message has been edited, but the UI still shows the word. The issue was identified to be due to displaying the value in the
mdproperty, and not themsgproperty, and themdis not edited to filter the bad words.This occurs due to bad word filter service running after the markdown parser.
Screen.Recording.2024-07-17.at.5.31.31.PM.mov
Issue(s)
Steps to test or reproduce
Further comments
SUP-624