Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Renders CodeMirrorBoxs full screen mode through portal #32818

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Jul 17, 2024

Backport of #32811

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner July 17, 2024 17:09
@dionisio-bot dionisio-bot bot requested a review from dougfabris July 17, 2024 17:09
Copy link

changeset-bot bot commented Jul 17, 2024

⚠️ No Changeset found

Latest commit: 8b120a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented Jul 17, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.11.0, but it targets 6.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.58%. Comparing base (edd0d74) to head (8b120a8).
Report is 1 commits behind head on release-6.10.1.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.10.1   #32818      +/-   ##
==================================================
- Coverage           56.60%   56.58%   -0.02%     
==================================================
  Files                2502     2502              
  Lines               55538    55538              
  Branches            11471    11470       -1     
==================================================
- Hits                31435    31425      -10     
- Misses              21413    21420       +7     
- Partials             2690     2693       +3     
Flag Coverage Δ
e2e 56.44% <60.00%> (-0.03%) ⬇️
unit 71.60% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Jul 18, 2024
@dougfabris dougfabris added this to the 6.11 milestone Jul 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 18, 2024
@kodiakhq kodiakhq bot merged commit 89b1dca into release-6.10.1 Jul 18, 2024
52 of 53 checks passed
@kodiakhq kodiakhq bot deleted the backport-6.10.1-32811 branch July 18, 2024 14:41
@dougfabris dougfabris modified the milestones: 6.11, 6.10.1 Jul 18, 2024
@ggazzo ggazzo modified the milestones: 6.10.1, 6.10 Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants