Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Agents can't leave omnichannel rooms that have already been closed #32819

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Jul 17, 2024

Backport of #32707

@dionisio-bot dionisio-bot bot requested review from a team as code owners July 17, 2024 17:53
Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: e19a25b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented Jul 17, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.10.1, but it targets 6.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 56.61%. Comparing base (edd0d74) to head (d396cfd).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.10.1   #32819      +/-   ##
==================================================
+ Coverage           56.60%   56.61%   +0.01%     
==================================================
  Files                2502     2503       +1     
  Lines               55538    55561      +23     
  Branches            11471    11478       +7     
==================================================
+ Hits                31435    31454      +19     
- Misses              21413    21420       +7     
+ Partials             2690     2687       -3     
Flag Coverage Δ
e2e 56.45% <50.00%> (-0.02%) ⬇️
unit 71.67% <86.36%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 added this to the 6.10.1 milestone Jul 17, 2024
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Jul 17, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 17, 2024
@kodiakhq kodiakhq bot merged commit 85baa32 into release-6.10.1 Jul 17, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the backport-6.10.1-32707 branch July 17, 2024 20:52
@ggazzo ggazzo modified the milestones: 6.10.1, 6.10 Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants