Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow admins to decide if email transcript should be sent always #32820

Merged
merged 22 commits into from
Jul 24, 2024

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Jul 17, 2024

Proposed changes (including videos or screenshots)

Added a new setting Livechat_transcript_send_always that allows admins to decide if email transcript should be sent all the times when a conversation is closed. This setting bypasses agent's preferences. For this setting to work, Livechat_enable_transcript should be off, meaning that visitors will no longer receive the option to decide if they want a transcript or not.

Note: When this setting is true, agent's preferences regarding email transcript will be disabled and ignored. The description of the preference was accommodated to let users know about this change.

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-496

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jul 17, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: 473bc6a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.47%. Comparing base (03c8b06) to head (3bb5c58).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32820      +/-   ##
===========================================
- Coverage    55.48%   55.47%   -0.02%     
===========================================
  Files         2636     2637       +1     
  Lines        57365    57391      +26     
  Branches     11881    11892      +11     
===========================================
+ Hits         31831    31836       +5     
- Misses       22837    22854      +17     
- Partials      2697     2701       +4     
Flag Coverage Δ
e2e 54.02% <77.77%> (-0.06%) ⬇️
unit 72.24% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review July 17, 2024 21:07
@KevLehman KevLehman requested review from a team as code owners July 17, 2024 21:07
.changeset/shaggy-hats-raise.md Outdated Show resolved Hide resolved
.changeset/shaggy-hats-raise.md Show resolved Hide resolved
packages/i18n/src/locales/en.i18n.json Outdated Show resolved Hide resolved
@casalsgh casalsgh modified the milestones: 6.11, 6.12 Jul 22, 2024
@casalsgh casalsgh modified the milestones: 6.12, 6.11 Jul 22, 2024
MartinSchoeler
MartinSchoeler previously approved these changes Jul 22, 2024
@renatobecker renatobecker added the stat: QA assured Means it has been tested and approved by a company insider label Jul 23, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 23, 2024
MartinSchoeler
MartinSchoeler previously approved these changes Jul 23, 2024
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Jul 23, 2024
Copy link
Contributor

kodiakhq bot commented Jul 23, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Jul 24, 2024
Copy link
Contributor

kodiakhq bot commented Jul 24, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Jul 24, 2024
@ggazzo ggazzo merged commit 393e613 into develop Jul 24, 2024
7 of 8 checks passed
@ggazzo ggazzo deleted the feat/always-send-transcript branch July 24, 2024 12:13
debdutdeb pushed a commit that referenced this pull request Jul 31, 2024
#32820)

Co-authored-by: Marcos Spessatto Defendi <[email protected]>
Co-authored-by: Guilherme Gazzo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants