-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: proxy avatars for Accounts_AvatarExternalProviderUrl #32824
Conversation
|
ccfdfe2
to
9323fbc
Compare
Looks like this PR is ready to merge! 🎉 |
@tassoevan sorry if I get it wrong. But now - as the pr is merged now - where can i activate the proxying of the external avatar url through the rocketchat server itself? Can't find the feature I added the pr for in the admin section anymore ;) |
@anicoa We discussed internally if a setting made more sense than just always proxying all the avatars requests. As we didn't find any strong reasons for maintaining the old behavior, the setting was ditched while the new behavior was kept. |
@tassoevan thanks for clarification and work. Found this right now in the code but could not reproduce the behaviour on a fresh updated 6.12 installation. Will try/investigate and report. |
@tassoevan checked the functionality with one 6.12.1 and one 6.12 installation.
Anything else I have to consider? |
Co-authored-by: Tasso <[email protected]> Co-authored-by: Guilherme Gazzo <[email protected]>
This PR adds the ability to proxy external avatars. Solves Issue #32812
Internal ticket: https://rocketchat.atlassian.net/browse/CONN-298