Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Settings list not displaying all groups #32829

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Jul 18, 2024

Backport of #32804

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner July 18, 2024 13:41
@dionisio-bot dionisio-bot bot requested a review from dougfabris July 18, 2024 13:41
Copy link

changeset-bot bot commented Jul 18, 2024

🦋 Changeset detected

Latest commit: 00848d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented Jul 18, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.10.1, but it targets 6.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.61%. Comparing base (89b1dca) to head (00848d0).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.10.1   #32829      +/-   ##
==================================================
- Coverage           56.61%   56.61%   -0.01%     
==================================================
  Files                2503     2503              
  Lines               55556    55561       +5     
  Branches            11475    11477       +2     
==================================================
+ Hits                31452    31454       +2     
+ Misses              21444    21415      -29     
- Partials             2660     2692      +32     
Flag Coverage Δ
e2e 56.48% <ø> (+0.03%) ⬆️
unit 71.61% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris added this to the 6.10.1 milestone Jul 18, 2024
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Jul 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 18, 2024
@kodiakhq kodiakhq bot merged commit 43feaab into release-6.10.1 Jul 18, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the backport-6.10.1-32804 branch July 18, 2024 17:19
@ggazzo ggazzo modified the milestones: 6.10.1, 6.9, 6.10 Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants