Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: block actions in federated rooms if federation configuration is invalid or it is disabled #32838

Merged

Conversation

debdutdeb
Copy link
Member

@debdutdeb debdutdeb commented Jul 18, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CORE-524

Copy link
Contributor

dionisio-bot bot commented Jul 18, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 18, 2024

⚠️ No Changeset found

Latest commit: 6c3d50c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 92.13483% with 7 lines in your changes missing coverage. Please review.

Project coverage is 59.39%. Comparing base (00df2e9) to head (6c3d50c).
Report is 6 commits behind head on federation-verify-config.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                    @@
##           federation-verify-config   #32838   +/-   ##
=========================================================
  Coverage                     59.38%   59.39%           
=========================================================
  Files                          2541     2543    +2     
  Lines                         63189    63190    +1     
  Branches                      14221    14219    -2     
=========================================================
+ Hits                          37527    37529    +2     
+ Misses                        22947    22945    -2     
- Partials                       2715     2716    +1     
Flag Coverage Δ
unit 75.95% <92.13%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@debdutdeb debdutdeb force-pushed the block-actions-if-federation-not-ready branch from d1c53a6 to a95395f Compare August 12, 2024 05:55
@debdutdeb debdutdeb requested a review from a team as a code owner August 14, 2024 13:52
apps/meteor/app/lib/server/functions/deleteMessage.ts Outdated Show resolved Hide resolved
apps/meteor/app/lib/server/functions/deleteMessage.ts Outdated Show resolved Hide resolved
apps/meteor/server/methods/addRoomOwner.ts Outdated Show resolved Hide resolved
apps/meteor/server/services/room/service.ts Outdated Show resolved Hide resolved
apps/meteor/server/services/room/hooks/FederationCheck.ts Outdated Show resolved Hide resolved
apps/meteor/server/services/messages/service.ts Outdated Show resolved Hide resolved
apps/meteor/server/services/room/hooks/FederationCheck.ts Outdated Show resolved Hide resolved
apps/meteor/server/services/federation/service.ts Outdated Show resolved Hide resolved
@debdutdeb debdutdeb force-pushed the block-actions-if-federation-not-ready branch from 09cc3ca to 1e6d187 Compare August 19, 2024 16:43
@debdutdeb debdutdeb force-pushed the block-actions-if-federation-not-ready branch from e9d28a0 to 1a7a143 Compare August 19, 2024 18:59
@debdutdeb debdutdeb merged commit 12b43e7 into federation-verify-config Aug 20, 2024
49 checks passed
@debdutdeb debdutdeb deleted the block-actions-if-federation-not-ready branch August 20, 2024 10:59
@casalsgh casalsgh added this to the 6.12 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants