Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: System messages are counted as agents' first responses in livechat rooms #32846

Merged
merged 37 commits into from
Aug 21, 2024

Conversation

matheusbsilva137
Copy link
Member

@matheusbsilva137 matheusbsilva137 commented Jul 19, 2024

Proposed changes (including videos or screenshots)

  • Stop considering system messages (such as "agent joined room") as agents' first responses in livechat rooms. This caused the "average first response time" and "best first respone time" metrics to be much lower than expected.

Issue(s)

Steps to test or reproduce

Add a new agent to the woskspace, then create a livechat conversation and make sure to serve it to the new agent. Then, go to Omnichannel > Analytics and set "Productivity" as the analytics type.

Current behavior: the "Best first response time" and "Average of first response time" metrics will always be lower than the actual time that the agent took to respond to the livechat room (eg possibly 1s). System messages (such as "agent joined room") are being interpreted as first responses, which causes these metrics to go much lower;
Expected behavior: RC should only consider a first response in a room when the agent sends a text message. System messages should be disconsidered in the "Best first response time" and "Average of first response time" metrics.

Further comments

CORE-562

@matheusbsilva137 matheusbsilva137 added this to the 6.12 milestone Jul 19, 2024
Copy link
Contributor

dionisio-bot bot commented Jul 19, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 19, 2024

🦋 Changeset detected

Latest commit: f7151c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.43%. Comparing base (eb5e60e) to head (f7151c7).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32846   +/-   ##
========================================
  Coverage    59.43%   59.43%           
========================================
  Files         2547     2547           
  Lines        63265    63265           
  Branches     14237    14250   +13     
========================================
  Hits         37604    37604           
  Misses       22941    22941           
  Partials      2720     2720           
Flag Coverage Δ
unit 76.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review July 23, 2024 18:50
@matheusbsilva137 matheusbsilva137 requested review from a team as code owners July 23, 2024 18:50
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some failing tests... Can you check those?

packages/core-typings/src/IMessage/IMessage.ts Outdated Show resolved Hide resolved
@matheusbsilva137 matheusbsilva137 marked this pull request as draft August 19, 2024 16:16
@matheusbsilva137
Copy link
Member Author

Converting this PR to draft since tests will only pass after #33022 gets merged

@KevLehman KevLehman marked this pull request as ready for review August 20, 2024 20:32
KevLehman
KevLehman previously approved these changes Aug 21, 2024
@matheusbsilva137 matheusbsilva137 dismissed stale reviews from ggazzo and MarcosSpessatto August 21, 2024 22:48

Changes addressed

@matheusbsilva137 matheusbsilva137 added the stat: ready to merge PR tested and approved waiting for merge label Aug 21, 2024
@kodiakhq kodiakhq bot merged commit 7937ff7 into develop Aug 21, 2024
48 checks passed
@kodiakhq kodiakhq bot deleted the fix/first-response-time-sys-messages branch August 21, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: core stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants