-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: System messages are counted as agents' first responses in livechat rooms #32846
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: f7151c7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32846 +/- ##
========================================
Coverage 59.43% 59.43%
========================================
Files 2547 2547
Lines 63265 63265
Branches 14237 14250 +13
========================================
Hits 37604 37604
Misses 22941 22941
Partials 2720 2720
Flags with carried forward coverage won't be shown. Click here to find out more. |
….com/RocketChat/Rocket.Chat into fix/first-response-time-sys-messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some failing tests... Can you check those?
…nto fix/first-response-time-sys-messages
Converting this PR to draft since tests will only pass after #33022 gets merged |
Changes addressed
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Add a new agent to the woskspace, then create a livechat conversation and make sure to serve it to the new agent. Then, go to Omnichannel > Analytics and set "Productivity" as the analytics type.
Current behavior: the "Best first response time" and "Average of first response time" metrics will always be lower than the actual time that the agent took to respond to the livechat room (eg possibly 1s). System messages (such as "agent joined room") are being interpreted as first responses, which causes these metrics to go much lower;
Expected behavior: RC should only consider a first response in a room when the agent sends a text message. System messages should be disconsidered in the "Best first response time" and "Average of first response time" metrics.
Further comments
CORE-562