fix: disable deletion for federated users

[debdutdeb]

Proposed changes (including videos or screenshots)

This PR disables the possibility of delete federated users.

Issue(s)

Steps to test or reproduce

Further comments

CORE-519

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: e968252

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.40%. Comparing base (19824bd) to head (e968252).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #32852   +/-   ##
========================================
  Coverage    59.40%   59.40%           
========================================
  Files         2541     2541           
  Lines        63181    63181           
  Branches     14222    14222           
========================================
  Hits         37531    37531           
  Misses       22935    22935           
  Partials      2715     2715           

Flag	Coverage Δ
unit	76.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[Gustrb]

Could you add API tests to assure the fix??

[debdutdeb]

@Gustrb I don't think we can.

a federated user (user.federated === true) can not be created externally. This kind of record is internally created.

Rocket.Chat/apps/meteor/server/services/federation/domain/FederatedUser.ts

Lines 45 to 56 in 7b7b8a3

	public static createLocalInstanceOnly(params: IFederatedUserCreationParams): IUser {
	return {
	username: params.username,
	name: params.name,
	type: 'user',
	status: UserStatus.ONLINE,
	active: true,
	roles: ['user'],
	requirePasswordChange: false,
	federated: !params.existsOnlyOnProxyServer,
	} as unknown as IUser;
	}

example event, before a dm is created -

Rocket.Chat/apps/meteor/ee/server/local-services/federation/application/room/sender/DirectMessageRoomServiceSender.ts

Line 47 in 7aa0d96

public async beforeDirectMessageRoomCreation(dmBeforeRoomCreationInput: FederationBeforeDirectMessageRoomCreationDto): Promise<void> {

If user is "external", then -

Rocket.Chat/apps/meteor/ee/server/local-services/federation/application/AbstractFederationApplicationServiceEE.ts

Lines 20 to 26 in c317739

	const externalUsersToBeCreatedLocally = invitees.filter(
	(invitee) =>
	!FederatedUserEE.isOriginalFromTheProxyServer(
	this.bridge.extractHomeserverOrigin(invitee.rawInviteeId),
	this.internalHomeServerDomain,
	),
	);

Right now, we could trigger for this user to be created. Problem is, we are blocking this in another pr until all of federation configuration is correct.

[debdutdeb]

Similar is for a user who participated in federation, i.e. have a mapped user in synapse.

[Gustrb]

I see, thanks for such a great explanation :)