Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: unknown contacts #32865

Merged
merged 105 commits into from
Sep 9, 2024
Merged

feat: unknown contacts #32865

merged 105 commits into from
Sep 9, 2024

Conversation

tapiarafael
Copy link
Member

@tapiarafael tapiarafael commented Jul 23, 2024 •
edited by jira bot
Loading

Proposed changes (including videos or screenshots)

Create an unknown contact every time a new visitor is created. If there's already a verified contact with the same email, just link the existent contact to the visitor

Issue(s)

Steps to test or reproduce

Further comments

SCI-47

tapiarafael and others added 30 commits June 27, 2024 16:06
@tapiarafael
feat: create contact entity
40312b9
@tapiarafael
feat: add create contact endpoint
668d934
@tapiarafael
add deprecation message to old endpoint
de25810
@tapiarafael
remove unused file
74c9ed8
@tapiarafael
fix: typo in prop
ae70c00
@tapiarafael
test: implement contact tests
20c3892
@tapiarafael
Merge branch 'develop' into feat/create-contact-endpoint
7e8dfa3
@tapiarafael
Create sixty-spoons-own.md
da25a9c
@tapiarafael
Update sixty-spoons-own.md
b7e0bf7
@tapiarafael @MarcosSpessatto
Update .changeset/sixty-spoons-own.md
675bb12 
Co-authored-by: Marcos Spessatto Defendi <[email protected]>
@tapiarafael
test: include custom fields validations
c59c4c2
@tapiarafael
test: ensure body is being validated
e13f736
@tapiarafael
test: ensure error message is equal the expected
e329740
@tapiarafael
test: ensure that it is possible to create contact with contact manag…
4b74679 
…er defined
@tapiarafael
feat: create new permission
8b1a303
@tapiarafael
fix: replace MeteorError to Error
3d26650
@tapiarafael
Merge branch 'develop' into feat/create-contact-endpoint
36b5021
@tapiarafael
refactor: deprecate old endpoint
9fe155c
@tapiarafael
Merge branch 'develop' into feat/create-contact-endpoint
8e7da69
@tapiarafael
fix: remove migration
35bc941
@tapiarafael
feat: implement update contact endpoint
9813b26
@tapiarafael
Create heavy-snails-help.md
1549a4e
@tapiarafael
Merge branch 'develop' into feat/create-contact-endpoint
e7b6048
@tapiarafael
Merge branch 'feat/create-contact-endpoint' into feat/update-contact-…
fc24f66 
…endpoint
@tapiarafael
Merge branch 'develop' into feat/create-contact-endpoint
6c908af
@tapiarafael
Merge branch 'feat/create-contact-endpoint' into feat/update-contact-…
a5c7ec5 
…endpoint
@tapiarafael
test: additional fields
b4c2686
@tapiarafael
test: create agent to test
af05b31
@tapiarafael
test: restore setting to the original value
06a656e
@tapiarafael
fix: set phones as required property
d61e15e
@tapiarafael tapiarafael marked this pull request as ready for review September 3, 2024 12:18
@tapiarafael tapiarafael requested review from a team as code owners September 3, 2024 12:18
@tapiarafael tapiarafael marked this pull request as draft September 3, 2024 12:19
Base automatically changed from feat/update-contact-endpoint to develop September 3, 2024 13:16
@tapiarafael tapiarafael marked this pull request as ready for review September 3, 2024 16:41
MarcosSpessatto
MarcosSpessatto approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth noting that these PRs don't contain changesets because the feature is not fully enabled yet; it's under a feature flag (test).

@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Sep 5, 2024
@tassoevan tassoevan added this to the 6.13 milestone Sep 5, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 5, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 6, 2024
@tapiarafael tapiarafael added the stat: ready to merge PR tested and approved waiting for merge label Sep 9, 2024
@kodiakhq kodiakhq bot merged commit 06dbf72 into develop Sep 9, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the feat/unknown-contacts branch September 9, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

@KevLehman KevLehman KevLehman approved these changes

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
6.13
Development

Successfully merging this pull request may close these issues.
4 participants
@tapiarafael @tassoevan @KevLehman @MarcosSpessatto