Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: Sending message when choose emoji from ComposerPopupBox #32886

Closed
wants to merge 1 commit into from
Closed

regression: Sending message when choose emoji from ComposerPopupBox #32886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,10 @@ const MessageBox = ({
const isSubmitKey = keyCode === keyCodes.CARRIAGE_RETURN || keyCode === keyCodes.NEW_LINE;

if (isSubmitKey) {
if (popup) {
return;
}

const withModifier = event.shiftKey || event.ctrlKey || event.altKey || event.metaKey;
const isSending = (sendOnEnter && !withModifier) || (!sendOnEnter && withModifier);

Expand Down Expand Up @@ -357,7 +361,8 @@ const MessageBox = ({
[handler],
);

const mergedRefs = useMessageComposerMergedRefs(c, textareaRef, callbackRef, autofocusRef, keyDownHandlerCallbackRef);
// TODO: Fix this! Parameter order matters here!
const mergedRefs = useMessageComposerMergedRefs(keyDownHandlerCallbackRef, c, textareaRef, callbackRef, autofocusRef);

const shouldPopupPreview = useEnablePopupPreview(filter, popup);

Expand Down
Loading