chore: Update Omnichannel's room closing mechanism to use transactions.

[KevLehman]

Proposed changes (including videos or screenshots)

• Use a transaction for closing omnichannel conversations. This will prevent rooms being on an invalid state and every time something happens it will allow users to retry.
• Currently, transaction covers only the core room closing mechanism. Sending a livechat-close message after the room is closed is not part of the scope (mainly because of the involved code changes to make all callbacks accept a session.
• When a transaction is aborted, user will receive a generic error message asking to try again.
• MongoDB transactions have its own quirks, so it was kept to the minimum amount of db calls for this time.

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-238

Steps to test or reproduce

Further comments

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: d3caae8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.38%. Comparing base (f6351e8) to head (d3caae8).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32896      +/-   ##
===========================================
- Coverage    59.39%   59.38%   -0.01%     
===========================================
  Files         2547     2547              
  Lines        63241    63241              
  Branches     14223    14225       +2     
===========================================
- Hits         37559    37558       -1     
- Misses       22974    22975       +1     
  Partials      2708     2708              

Flag	Coverage Δ
unit	75.84% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[MarcosSpessatto]

I wouldn't like to start to spread MongoDB (or any other DB) transaction mechanism into business rules code, this could open a wormhole to dark places, but I understand your point here. For this specific case I'm okay with it, but for sure we need a more concrete and robust solution for using DB transactions.

[KevLehman]

Yup, kinda the same shared on the chapter. This facilitates this specific problem but it can create new ones (hopefully not).

We would need to check on how this behaves during testing to ensure it won't add more problems than it solves.

And ideally, we would have a nicer api for dealing with this after mongo3 (where we can have some async storage that allows to pass data down to the models without editing the whole chain).

[kodiakhq]

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.