Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(audit): New endpoint for listing members of any room #32916

Merged
merged 20 commits into from
Aug 12, 2024

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Jul 26, 2024

Proposed changes (including videos or screenshots)

  • New endpoint created /audit/rooms.members
  • Allows users with view-members-list-all-rooms permission to audit any room (public or private) and see the members of them.
  • Part of Audit EE module

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-565

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jul 26, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 26, 2024

🦋 Changeset detected

Latest commit: f613c82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/i18n Minor
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.30%. Comparing base (08ac2f3) to head (f613c82).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32916      +/-   ##
===========================================
- Coverage    59.40%   58.30%   -1.10%     
===========================================
  Files         2541     2675     +134     
  Lines        63178    65033    +1855     
  Branches     14219    14670     +451     
===========================================
+ Hits         37532    37920     +388     
- Misses       22931    24366    +1435     
- Partials      2715     2747      +32     
Flag Coverage Δ
unit 76.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman added this to the 6.12 milestone Jul 26, 2024
@KevLehman KevLehman marked this pull request as ready for review July 26, 2024 19:44
@KevLehman KevLehman requested a review from a team as a code owner July 26, 2024 19:44
.changeset/funny-boats-guess.md Outdated Show resolved Hide resolved
apps/meteor/ee/server/lib/audit/endpoints.ts Outdated Show resolved Hide resolved
apps/meteor/ee/server/lib/audit/endpoints.ts Outdated Show resolved Hide resolved
apps/meteor/ee/server/lib/audit/endpoints.ts Outdated Show resolved Hide resolved
apps/meteor/tests/end-to-end/api/audit.ts Outdated Show resolved Hide resolved
apps/meteor/tests/end-to-end/api/audit.ts Show resolved Hide resolved
apps/meteor/tests/end-to-end/api/audit.ts Show resolved Hide resolved
apps/meteor/ee/server/lib/audit/endpoints.ts Outdated Show resolved Hide resolved
packages/i18n/src/locales/en.i18n.json Show resolved Hide resolved
@KevLehman KevLehman requested review from a team as code owners July 29, 2024 15:38
packages/core-typings/src/ee/IAuditLog.ts Show resolved Hide resolved
packages/i18n/src/locales/en.i18n.json Outdated Show resolved Hide resolved
apps/meteor/ee/server/lib/audit/endpoints.ts Outdated Show resolved Hide resolved
apps/meteor/ee/server/lib/audit/endpoints.ts Outdated Show resolved Hide resolved
apps/meteor/ee/server/lib/audit/endpoints.ts Outdated Show resolved Hide resolved
apps/meteor/ee/server/lib/audit/endpoints.ts Outdated Show resolved Hide resolved
apps/meteor/ee/server/lib/audit/endpoints.ts Outdated Show resolved Hide resolved
csuadev
csuadev previously approved these changes Jul 31, 2024
@julio-cfa julio-cfa self-requested a review August 1, 2024 13:15
julio-cfa
julio-cfa previously approved these changes Aug 1, 2024
apps/meteor/ee/server/lib/audit/endpoints.ts Outdated Show resolved Hide resolved
apps/meteor/ee/server/lib/audit/endpoints.ts Outdated Show resolved Hide resolved
apps/meteor/ee/server/lib/audit/endpoints.ts Outdated Show resolved Hide resolved
apps/meteor/ee/server/startup/audit.ts Outdated Show resolved Hide resolved
apps/meteor/tests/end-to-end/api/audit.ts Show resolved Hide resolved
apps/meteor/tests/end-to-end/api/audit.ts Show resolved Hide resolved
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Aug 8, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 8, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 12, 2024
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Aug 12, 2024
@kodiakhq kodiakhq bot merged commit 127866c into develop Aug 12, 2024
48 of 49 checks passed
@kodiakhq kodiakhq bot deleted the feat/audit-room-members branch August 12, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants