Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: imported fixes #32919

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix: imported fixes #32919

merged 1 commit into from
Jul 29, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Jul 26, 2024

Backport of #32894

@dionisio-bot dionisio-bot bot requested review from a team as code owners July 26, 2024 21:17
@dionisio-bot dionisio-bot bot requested a review from sampaiodiego July 26, 2024 21:17
Copy link

changeset-bot bot commented Jul 26, 2024

🦋 Changeset detected

Latest commit: 6312f7c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented Jul 26, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@dionisio-bot dionisio-bot bot removed the backport label Jul 26, 2024
@dionisio-bot dionisio-bot bot mentioned this pull request Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 89.83051% with 6 lines in your changes missing coverage. Please review.

Project coverage is 55.55%. Comparing base (b5cba4a) to head (6312f7c).
Report is 1 commits behind head on release-6.8.5.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.8.5   #32919      +/-   ##
=================================================
+ Coverage          55.00%   55.55%   +0.55%     
=================================================
  Files               2315     2373      +58     
  Lines              51079    52079    +1000     
  Branches           10375    10655     +280     
=================================================
+ Hits               28095    28935     +840     
- Misses             20540    20604      +64     
- Partials            2444     2540      +96     
Flag Coverage Δ
e2e 54.75% <ø> (+0.95%) ⬆️
unit 75.46% <89.83%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego merged commit ce21727 into release-6.8.5 Jul 29, 2024
45 checks passed
@sampaiodiego sampaiodiego deleted the backport-6.8.5-32894 branch July 29, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant