Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Remove unused omnichannelExternalFrameGenerateKey #32921

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jul 26, 2024

Proposed changes (including videos or screenshots)

  • Removes unused omnichannelExternalFrameGenerateKey meteor method
  • Removes unused Omnichannel_External_Frame_GenerateKey setting

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jul 26, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 26, 2024

⚠️ No Changeset found

Latest commit: 1086e69

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 7.0 milestone Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.00%. Comparing base (1eae86e) to head (1086e69).
Report is 2 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #32921   +/-   ##
==============================================
  Coverage          55.00%   55.00%           
==============================================
  Files               2596     2596           
  Lines              56003    56003           
  Branches           11589    11589           
==============================================
  Hits               30802    30802           
  Misses             22558    22558           
  Partials            2643     2643           
Flag Coverage Δ
unit 73.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the release-7.0.0 branch 2 times, most recently from ce44882 to d94b784 Compare July 29, 2024 19:47
@dougfabris dougfabris force-pushed the chore/generateNewKey branch 2 times, most recently from f27d384 to a4d8045 Compare July 29, 2024 21:57
@ggazzo ggazzo marked this pull request as ready for review August 15, 2024 19:49
@ggazzo ggazzo requested review from a team as code owners August 15, 2024 19:49
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 15, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 15, 2024
@ggazzo ggazzo merged commit 0055c11 into release-7.0.0 Aug 15, 2024
51 checks passed
@ggazzo ggazzo deleted the chore/generateNewKey branch August 15, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants