-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: File uploads should only be allowed for room members #32940
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: aee2cd6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32940 +/- ##
===========================================
- Coverage 59.39% 59.39% -0.01%
===========================================
Files 2541 2541
Lines 63180 63179 -1
Branches 14221 14220 -1
===========================================
- Hits 37528 37527 -1
Misses 22936 22936
Partials 2716 2716
Flags with carried forward coverage won't be shown. Click here to find out more. |
apps/meteor/client/views/room/body/hooks/useFileUploadDropTarget.ts
Outdated
Show resolved
Hide resolved
…/Rocket.Chat into fileUpload-not-member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is such a complete work, congrats on that!
Proposed changes (including videos or screenshots)
Currently non channel members can drag and drop files into a channel they do not belong, this PR fixes that
Issue(s)
CORE-205