Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add departmentName to the return values of :agentId/departments endpoint #32943

Merged
merged 11 commits into from
Aug 12, 2024

Conversation

KevLehman
Copy link
Contributor

Proposed changes (including videos or screenshots)

  • Adds a new departmentName key to the object returned from the :agentId/departments endpoint in Omnichannel.
  • This will help to avoid some pagination problems on the UI (that will be fixed on another PR)

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-623

Steps to test or reproduce

Further comments

Apparently the tests for this endpoint were not running, so those were fixed too. (Tests were made EE because of the limitation of departments on CE)

Copy link
Contributor

dionisio-bot bot commented Jul 30, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 30, 2024

⚠️ No Changeset found

Latest commit: 7de8b2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KevLehman KevLehman changed the title fix: Add departmentName to the return values of :agentId/departments endpoint chore: Add departmentName to the return values of :agentId/departments endpoint Jul 30, 2024
@KevLehman KevLehman added this to the 6.12 milestone Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.40%. Comparing base (27bd512) to head (7de8b2f).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32943      +/-   ##
===========================================
- Coverage    59.41%   59.40%   -0.01%     
===========================================
  Files         2541     2541              
  Lines        63187    63179       -8     
  Branches     14221    14219       -2     
===========================================
- Hits         37540    37533       -7     
  Misses       22931    22931              
+ Partials      2716     2715       -1     
Flag Coverage Δ
unit 76.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review July 30, 2024 22:48
@KevLehman KevLehman requested review from a team as code owners July 30, 2024 22:48
@KevLehman
Copy link
Contributor Author

@MarcosSpessatto feel we can skip QA on this one as QA will be performed when the UI connects with it, wdyt?

@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Aug 1, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 1, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 9, 2024
@ggazzo ggazzo removed the stat: QA assured Means it has been tested and approved by a company insider label Aug 12, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 12, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 12, 2024
@kodiakhq kodiakhq bot merged commit ccf6828 into develop Aug 12, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/add-departmentname-to-departments-endp branch August 12, 2024 12:46
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants