-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add departmentName
to the return values of :agentId/departments
endpoint
#32943
chore: Add departmentName
to the return values of :agentId/departments
endpoint
#32943
Conversation
Looks like this PR is ready to merge! 🎉 |
|
departmentName
to the return values of :agentId/departments
endpoint departmentName
to the return values of :agentId/departments
endpoint
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32943 +/- ##
===========================================
- Coverage 59.41% 59.40% -0.01%
===========================================
Files 2541 2541
Lines 63187 63179 -8
Branches 14221 14219 -2
===========================================
- Hits 37540 37533 -7
Misses 22931 22931
+ Partials 2716 2715 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
@MarcosSpessatto feel we can skip QA on this one as QA will be performed when the UI connects with it, wdyt? |
Proposed changes (including videos or screenshots)
departmentName
key to the object returned from the:agentId/departments
endpoint in Omnichannel.Issue(s)
https://rocketchat.atlassian.net/browse/SUP-623
Steps to test or reproduce
Further comments
Apparently the tests for this endpoint were not running, so those were fixed too. (Tests were made EE because of the limitation of departments on CE)