Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mark as unread redirecting even if you don't have the channel open #32971

Draft
wants to merge 31 commits into
base: develop
Choose a base branch
from

Conversation

MartinSchoeler
Copy link
Contributor

Proposed changes (including videos or screenshots)

Fixed issue that caused the mark as unread channel action to redirect you to home, even if you didn't have the channel currently open

Requires #32939

Copy link
Contributor

dionisio-bot bot commented Aug 2, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 2, 2024

⚠️ No Changeset found

Latest commit: 0f3c88c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MartinSchoeler MartinSchoeler changed the title Fix/mark unread redirect fix: Mark as unread redirecting even if you don't have the channel open Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.80%. Comparing base (f07fcc5) to head (0f3c88c).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           fix/mark-unread   #32971      +/-   ##
===================================================
+ Coverage            59.32%   59.80%   +0.48%     
===================================================
  Files                 2547     2546       -1     
  Lines                63345    63240     -105     
  Branches             14258    14231      -27     
===================================================
+ Hits                 37579    37822     +243     
+ Misses               23061    22998      -63     
+ Partials              2705     2420     -285     
Flag Coverage Δ
unit 77.22% <ø> (+2.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Base automatically changed from fix/mark-unread to develop September 18, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants