-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Mark as unread redirecting even if you don't have the channel open #32971
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix/mark-unread #32971 +/- ##
===================================================
+ Coverage 59.32% 59.80% +0.48%
===================================================
Files 2547 2546 -1
Lines 63345 63240 -105
Branches 14258 14231 -27
===================================================
+ Hits 37579 37822 +243
+ Misses 23061 22998 -63
+ Partials 2705 2420 -285
Flags with carried forward coverage won't be shown. Click here to find out more. |
9607d53
to
e5c54db
Compare
Proposed changes (including videos or screenshots)
Fixed issue that caused the
mark as unread
channel action to redirect you to home, even if you didn't have the channel currently openRequires #32939