Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add updater on afterOmnichannelSaveMessage (save-last-visitor-message-timestamp) hook #32977

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented Aug 5, 2024

As per OPI-12, this pull request updates afterOmnichannelSaveMessage - save-last-visitor-message-timestamp hook adding updater implemented on #32948. The goal is to streamline the call stack and eliminate unnecessary database calls.

Copy link

changeset-bot bot commented Aug 5, 2024

⚠️ No Changeset found

Latest commit: 34220c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Aug 5, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@ricardogarim ricardogarim changed the base branch from develop to chore/afterOmnichannelSaveMessage-updater August 5, 2024 02:08
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.00%. Comparing base (e2a750f) to head (34220c6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32977   +/-   ##
========================================
  Coverage    55.00%   55.00%           
========================================
  Files         2596     2596           
  Lines        56006    56006           
  Branches     11589    11589           
========================================
  Hits         30804    30804           
  Misses       22559    22559           
  Partials      2643     2643           
Flag Coverage Δ
unit 73.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the chore/afterOmnichannelSaveMessage-updater branch from 8cb5a83 to adca51e Compare August 5, 2024 16:52
Base automatically changed from chore/afterOmnichannelSaveMessage-updater to develop August 5, 2024 18:19
@ricardogarim ricardogarim changed the title chore: add updater on afterSaveMessage (save-last-visitor-message-timestamp) hook chore: add updater on afterOmnichannelSaveMessage (save-last-visitor-message-timestamp) hook Aug 5, 2024
@ggazzo ggazzo added this to the 6.12 milestone Aug 5, 2024
@ggazzo ggazzo marked this pull request as ready for review August 5, 2024 21:26
@ggazzo ggazzo requested review from a team as code owners August 5, 2024 21:26
@ggazzo ggazzo merged commit cf778f1 into develop Aug 5, 2024
50 checks passed
@ggazzo ggazzo deleted the chore/saveLastVisitorMessageTs-with-updater branch August 5, 2024 21:26
gabriellsh added a commit that referenced this pull request Aug 7, 2024
…Chat into improve/threadMetrics

* 'improve/threadMetrics' of github.com:RocketChat/Rocket.Chat:
  chore: add updater on afterOmnichannelSaveMessage (save-last-visitor-message-timestamp) hook (#32977)
  chore: move afterOmnichannelSaveMessage hook to work with updater (#32978)
  feat: Upgrade `fuselage-toastbar` adding pause on hover (#32969)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants