Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Following/unfollowing a message when the thread is closed does not update the UI #32981

Merged
merged 11 commits into from
Aug 20, 2024

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Aug 5, 2024

Proposed changes (including videos or screenshots)

The follow/unfollow methods were not notifying a collection change.

Issue(s)

CORE-542

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Aug 5, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 5, 2024

🦋 Changeset detected

Latest commit: 949087a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.35%. Comparing base (f20be47) to head (949087a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32981      +/-   ##
===========================================
- Coverage    59.40%   58.35%   -1.05%     
===========================================
  Files         2543     2677     +134     
  Lines        63183    64956    +1773     
  Branches     14220    14643     +423     
===========================================
+ Hits         37533    37907     +374     
- Misses       22934    24310    +1376     
- Partials      2716     2739      +23     
Flag Coverage Δ
unit 76.03% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabriellsh gabriellsh marked this pull request as ready for review August 5, 2024 19:15
@gabriellsh gabriellsh requested a review from a team as a code owner August 5, 2024 19:15
@gabriellsh gabriellsh added this to the 6.12 milestone Aug 5, 2024
apps/meteor/tests/e2e/message-actions.spec.ts Outdated Show resolved Hide resolved
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of frontend team!

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Aug 20, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 20, 2024
@kodiakhq kodiakhq bot merged commit 0e749e2 into develop Aug 20, 2024
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the fix/followThread branch August 20, 2024 16:30
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants