Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add updater on afterOmnichannelSaveMessage (markRoomResponded) hook #32983

Merged
merged 11 commits into from
Aug 7, 2024

Conversation

ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented Aug 5, 2024

As per OPI-12, this pull request updates afterOmnichannelSaveMessage - markRoomResponded hook adding updater implemented on #32948. The goal is to streamline the call stack and eliminate unnecessary database calls.

Copy link
Contributor

dionisio-bot bot commented Aug 5, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 5, 2024

⚠️ No Changeset found

Latest commit: ac90af4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.98%. Comparing base (2c72a26) to head (ac90af4).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32983      +/-   ##
===========================================
- Coverage    54.98%   54.98%   -0.01%     
===========================================
  Files         2596     2596              
  Lines        55970    55966       -4     
  Branches     11584    11585       +1     
===========================================
- Hits         30775    30771       -4     
+ Misses       22553    22552       -1     
- Partials      2642     2643       +1     
Flag Coverage Δ
unit 73.05% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added this to the 6.12 milestone Aug 6, 2024
@ggazzo ggazzo marked this pull request as ready for review August 7, 2024 19:47
@ggazzo ggazzo requested review from a team as code owners August 7, 2024 19:47
@ricardogarim ricardogarim force-pushed the chore/markRoomResponded-with-updater branch from b8bd1a6 to ac90af4 Compare August 7, 2024 20:20
@ggazzo ggazzo merged commit 5388eef into develop Aug 7, 2024
49 checks passed
@ggazzo ggazzo deleted the chore/markRoomResponded-with-updater branch August 7, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants