Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fuselage-ui-kit): MultiStaticSelectElement not working as expected #32999

Merged
merged 14 commits into from
Sep 5, 2024

Conversation

tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Aug 7, 2024

Proposed changes (including videos or screenshots)

Change actionFunction in useUiKitState to update the state value correctly when using MultiStaticSelectElement from UiKit

Issue(s)

Steps to test or reproduce

Further comments

SUP-629

Copy link
Contributor

dionisio-bot bot commented Aug 7, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.13.0, but it targets 6.12.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 7, 2024

🦋 Changeset detected

Latest commit: d49b8fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tiagoevanp tiagoevanp added this to the 6.12 milestone Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 59.32%. Comparing base (3ba1854) to head (d49b8fa).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32999      +/-   ##
===========================================
+ Coverage    59.31%   59.32%   +0.01%     
===========================================
  Files         2547     2547              
  Lines        63343    63346       +3     
  Branches     14252    14254       +2     
===========================================
+ Hits         37570    37581      +11     
+ Misses       23070    23062       -8     
  Partials      2703     2703              
Flag Coverage Δ
unit 75.23% <28.57%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tiagoevanp tiagoevanp marked this pull request as ready for review August 7, 2024 17:00
@tiagoevanp tiagoevanp requested a review from a team as a code owner August 7, 2024 17:00
MarcosSpessatto
MarcosSpessatto previously approved these changes Aug 8, 2024
Copy link
Contributor

@tassoevan tassoevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing 'on_item_selected' or not passing it makes no difference to the unit test. Even reverting the useUiKitState hook just fail the test in both scenarios.

@scuciatto scuciatto removed this from the 6.12 milestone Aug 20, 2024
@tiagoevanp tiagoevanp changed the title fix(fuselage-ui-kit): MultiStaticSelectElement not working as expected using dispatchActionConfig: ['on_item_selected'] fix(fuselage-ui-kit): MultiStaticSelectElement not working as expected using Aug 28, 2024
@tiagoevanp tiagoevanp changed the title fix(fuselage-ui-kit): MultiStaticSelectElement not working as expected using fix(fuselage-ui-kit): MultiStaticSelectElement not working as expected Aug 28, 2024
MarcosSpessatto
MarcosSpessatto previously approved these changes Sep 2, 2024
@MarcosSpessatto MarcosSpessatto added this to the 6.13 milestone Sep 2, 2024
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Sep 5, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 5, 2024
@kodiakhq kodiakhq bot merged commit 78e6ba4 into develop Sep 5, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/dispatch-action-config branch September 5, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants