Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow apps to react/unreact to messages #33001

Merged
merged 7 commits into from
Aug 21, 2024
Merged

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Aug 7, 2024

Proposed changes (including videos or screenshots)

Adds bridge for apps to use core's reaction functions

Issue(s)

rocketchat.atlassian.net/browse/CORE-594

Steps to test or reproduce

Further comments

https://github.com/RocketChat/adrs/pull/105

Copy link
Contributor

dionisio-bot bot commented Aug 7, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 7, 2024

🦋 Changeset detected

Latest commit: a5c8aed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.43%. Comparing base (2b13061) to head (a5c8aed).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33001   +/-   ##
========================================
  Coverage    59.43%   59.43%           
========================================
  Files         2546     2546           
  Lines        63255    63255           
  Branches     14235    14235           
========================================
  Hits         37594    37594           
  Misses       22941    22941           
  Partials      2720     2720           
Flag Coverage Δ
unit 76.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

tapiarafael
tapiarafael previously approved these changes Aug 16, 2024
@KevLehman KevLehman added this to the 6.12 milestone Aug 21, 2024
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Aug 21, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 21, 2024
@KevLehman KevLehman marked this pull request as ready for review August 21, 2024 14:48
@KevLehman KevLehman requested review from a team as code owners August 21, 2024 14:48
@kodiakhq kodiakhq bot merged commit ed4ea30 into develop Aug 21, 2024
45 checks passed
@kodiakhq kodiakhq bot deleted the feat/reactions-bridge branch August 21, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants