Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create getVisitorActiveForPeriodUpdateQuery #33017

Merged

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Aug 8, 2024

https://rocketchat.atlassian.net/browse/OPI-28

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Aug 8, 2024

⚠️ No Changeset found

Latest commit: 79f77be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Aug 8, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (chore/accumulator@1cf5983). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##             chore/accumulator   #33017   +/-   ##
====================================================
  Coverage                     ?   54.98%           
====================================================
  Files                        ?     2596           
  Lines                        ?    55966           
  Branches                     ?    11585           
====================================================
  Hits                         ?    30771           
  Misses                       ?    22552           
  Partials                     ?     2643           
Flag Coverage Δ
unit 73.05% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the chore/roomUpdater.getVisitorActiveForPeriodUpdateQuery branch 3 times, most recently from 33cab33 to a7fe604 Compare August 9, 2024 00:13
@ggazzo ggazzo changed the base branch from develop to chore/accumulator August 9, 2024 00:14
@ggazzo ggazzo marked this pull request as ready for review August 9, 2024 00:14
@ggazzo ggazzo requested review from a team as code owners August 9, 2024 00:14
@ggazzo ggazzo added this to the 6.12 milestone Aug 9, 2024
ricardogarim
ricardogarim previously approved these changes Aug 9, 2024
Base automatically changed from chore/accumulator to develop August 9, 2024 12:38
@ggazzo ggazzo dismissed ricardogarim’s stale review August 9, 2024 12:38

The base branch was changed.

@ggazzo ggazzo force-pushed the chore/roomUpdater.getVisitorActiveForPeriodUpdateQuery branch from a7fe604 to 79f77be Compare August 9, 2024 12:42
@ggazzo ggazzo merged commit 7fc1d3e into develop Aug 9, 2024
4 of 6 checks passed
@ggazzo ggazzo deleted the chore/roomUpdater.getVisitorActiveForPeriodUpdateQuery branch August 9, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants