Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create getNotResponseByRoomIdUpdateQuery method #33021

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented Aug 9, 2024

This pull request addresses the requirements of OPI-27 by adding updater support to the afterOmnichannelSaveMessage.markRoomNotResponded hook - that aims to optimize performance by reducing database calls related to omnichannel rooms.

Copy link
Contributor

dionisio-bot bot commented Aug 9, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 9, 2024

⚠️ No Changeset found

Latest commit: 7e31562

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ricardogarim ricardogarim marked this pull request as ready for review August 9, 2024 15:57
@ricardogarim ricardogarim requested review from a team as code owners August 9, 2024 15:57
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.98%. Comparing base (7fc1d3e) to head (7e31562).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33021   +/-   ##
========================================
  Coverage    54.98%   54.98%           
========================================
  Files         2596     2596           
  Lines        55966    55964    -2     
  Branches     11585    11585           
========================================
- Hits         30771    30770    -1     
+ Misses       22552    22551    -1     
  Partials      2643     2643           
Flag Coverage Δ
unit 73.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added this to the 6.12 milestone Aug 9, 2024
@ggazzo ggazzo merged commit 9f50aaf into develop Aug 9, 2024
50 checks passed
@ggazzo ggazzo deleted the chore/roomUpdater.getNotResponseByRoomIdUpdateQuery branch August 9, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants