-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Realtime Monitoring LineCharts not updating #33023
Conversation
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33023 +/- ##
========================================
Coverage 59.40% 59.40%
========================================
Files 2541 2541
Lines 63176 63176
Branches 14220 14220
========================================
Hits 37527 37527
Misses 22934 22934
Partials 2715 2715
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way of adding some tests here?
I don't think so, all of the charts are drawn into canvases, and I don't think playwright supports canvas, I do have some ideas for testing, but I'll probably add those to the refactors to TS of the Charts that I'm working on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering, why do we have two separate components for ChatsPerAgent and ChatsPerDepartment if they are exactly the same component with data from different endpoints?
To avoid a refactor, this fix will be backported, and we do not backport refactors, I'm currently working on a refactor that will resolve this issue |
d14285b
7ac3b07
to
d30191e
Compare
/patch |
Pull request #33086 added to Project: "Patch 6.11.2" |
/backport 6.10.5 |
Pull request #33089 added to Project: "Patch 6.10.5" |
/backport 6.9.6 |
Pull request #33090 added to Project: "undefined" |
SUP-637
Proposed changes (including videos or screenshots)
Today, the Realtime Charts have a couple of problems, like not being able to swap data labels, poor redrawing logic, and issues refreshing existing charts, this PR tries to mitigate the issues, but we will only fully fix this with a good refactor of this code
Issue(s)
Steps to test or reproduce
Further comments