Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Realtime Monitoring LineCharts not updating #33023

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Aug 9, 2024

SUP-637

Proposed changes (including videos or screenshots)

Today, the Realtime Charts have a couple of problems, like not being able to swap data labels, poor redrawing logic, and issues refreshing existing charts, this PR tries to mitigate the issues, but we will only fully fix this with a good refactor of this code

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Aug 9, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 9, 2024

⚠️ No Changeset found

Latest commit: 744a330

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.40%. Comparing base (9048692) to head (744a330).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33023   +/-   ##
========================================
  Coverage    59.40%   59.40%           
========================================
  Files         2541     2541           
  Lines        63176    63176           
  Branches     14220    14220           
========================================
  Hits         37527    37527           
  Misses       22934    22934           
  Partials      2715     2715           
Flag Coverage Δ
unit 76.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review August 12, 2024 13:25
@MartinSchoeler MartinSchoeler requested review from a team as code owners August 12, 2024 13:25
@MarcosSpessatto MarcosSpessatto added this to the 6.12 milestone Aug 12, 2024
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way of adding some tests here?

@MartinSchoeler
Copy link
Contributor Author

Is there any way of adding some tests here?

I don't think so, all of the charts are drawn into canvases, and I don't think playwright supports canvas, I do have some ideas for testing, but I'll probably add those to the refactors to TS of the Charts that I'm working on

Copy link
Contributor

@csuadev csuadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, why do we have two separate components for ChatsPerAgent and ChatsPerDepartment if they are exactly the same component with data from different endpoints?

@MartinSchoeler
Copy link
Contributor Author

Just wondering, why do we have two separate components for ChatsPerAgent and ChatsPerDepartment if they are exactly the same component with data from different endpoints?

To avoid a refactor, this fix will be backported, and we do not backport refactors, I'm currently working on a refactor that will resolve this issue

csuadev
csuadev previously approved these changes Aug 13, 2024
KevLehman
KevLehman previously approved these changes Aug 13, 2024
KevLehman
KevLehman previously approved these changes Aug 13, 2024
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Aug 15, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 15, 2024
@kodiakhq kodiakhq bot merged commit c8dac9f into develop Aug 16, 2024
47 checks passed
@kodiakhq kodiakhq bot deleted the fix-realtime-reload branch August 16, 2024 15:40
@scuciatto
Copy link
Member

/patch

Copy link
Contributor

dionisio-bot bot commented Aug 19, 2024

Pull request #33086 added to Project: "Patch 6.11.2"

@scuciatto
Copy link
Member

/backport 6.10.5

Copy link
Contributor

dionisio-bot bot commented Aug 19, 2024

Pull request #33089 added to Project: "Patch 6.10.5"

@scuciatto
Copy link
Member

/backport 6.9.6

Copy link
Contributor

dionisio-bot bot commented Aug 19, 2024

Pull request #33090 added to Project: "undefined"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants