Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): fixes onboarding.component.emailCodeFallback translation #33029

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

lucas-a-pelegrino
Copy link
Contributor

@lucas-a-pelegrino lucas-a-pelegrino commented Aug 12, 2024

Proposed changes (including videos or screenshots)

This PR fixes a translation text typo for German, where einmal was written as einemal. It also includes the missing hyperlinks for Resend and Change Email.

image

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-632

Steps to test or reproduce

  1. Set language to German
  2. Go through the four steps of workspace registration

Further comments

N/a

@lucas-a-pelegrino lucas-a-pelegrino self-assigned this Aug 12, 2024
Copy link
Contributor

dionisio-bot bot commented Aug 12, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 12, 2024

🦋 Changeset detected

Latest commit: 7823b17

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/i18n Patch
@rocket.chat/meteor Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/ui-client Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2024

CLA assistant check
All committers have signed the CLA.

@lucas-a-pelegrino lucas-a-pelegrino added this to the 6.12 milestone Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.40%. Comparing base (938337f) to head (7823b17).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33029   +/-   ##
========================================
  Coverage    59.40%   59.40%           
========================================
  Files         2541     2541           
  Lines        63178    63178           
  Branches     14223    14223           
========================================
  Hits         37532    37532           
  Misses       22931    22931           
  Partials      2715     2715           
Flag Coverage Δ
unit 76.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@lucas-a-pelegrino lucas-a-pelegrino changed the title fix(i18n): fixes onboarding.component.emailCodeFallback translation i18n: fixes onboarding.component.emailCodeFallback translation Aug 12, 2024
@lucas-a-pelegrino lucas-a-pelegrino marked this pull request as ready for review August 12, 2024 20:15
dougfabris
dougfabris previously approved these changes Aug 12, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add a changeset

yarn.lock Outdated Show resolved Hide resolved
@lucas-a-pelegrino lucas-a-pelegrino changed the title i18n: fixes onboarding.component.emailCodeFallback translation fix(i18n): fixes onboarding.component.emailCodeFallback translation Aug 12, 2024
@gabriellsh gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label Aug 13, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 13, 2024
@kodiakhq kodiakhq bot merged commit 1f061a1 into develop Aug 13, 2024
47 checks passed
@kodiakhq kodiakhq bot deleted the fix/SUP-632 branch August 13, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants