Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Cover implicit any types #33030

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

It ensures some function parameters are properly typed instead of implicitly resolved with the any type.

Issue(s)

Steps to test or reproduce

Further comments

This issues were discovered by bumping @types/react and @types/react-dom in a PoC. Changing them in advance will ease the upgrade to React 18.

@tassoevan tassoevan added this to the 6.12 milestone Aug 13, 2024
@tassoevan tassoevan requested a review from a team August 13, 2024 05:38
Copy link
Contributor

dionisio-bot bot commented Aug 13, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 13, 2024

⚠️ No Changeset found

Latest commit: e6a0f8e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.40%. Comparing base (c11f372) to head (e6a0f8e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33030   +/-   ##
========================================
  Coverage    59.40%   59.40%           
========================================
  Files         2541     2541           
  Lines        63178    63178           
  Branches     14219    14223    +4     
========================================
  Hits         37532    37532           
  Misses       22931    22931           
  Partials      2715     2715           
Flag Coverage Δ
unit 76.06% <72.72%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 13, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 13, 2024
@kodiakhq kodiakhq bot merged commit d9995a2 into develop Aug 13, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the refactor/inconsistent-types branch August 13, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants