Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: processRoomAbandonment callback not processing data correctly #33036

Merged
merged 8 commits into from
Aug 20, 2024

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Aug 13, 2024

Proposed changes (including videos or screenshots)

  • Prevent callback from failing when BH configuration doesn't include all fields
  • Fix internal callback logic to properly calculate data

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-619

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Aug 13, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 13, 2024

🦋 Changeset detected

Latest commit: 11fbb28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.44%. Comparing base (d828b44) to head (11fbb28).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33036      +/-   ##
===========================================
+ Coverage    59.40%   59.44%   +0.03%     
===========================================
  Files         2543     2544       +1     
  Lines        63180    63251      +71     
  Branches     14219    14240      +21     
===========================================
+ Hits         37532    37598      +66     
  Misses       22933    22933              
- Partials      2715     2720       +5     
Flag Coverage Δ
unit 76.09% <92.85%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review August 13, 2024 19:11
@KevLehman KevLehman requested review from a team as code owners August 13, 2024 19:11
@KevLehman KevLehman added this to the 6.12 milestone Aug 13, 2024
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to split the 2 fixes you mentioned in 2 different PRs, since we are changing the way things are calculated, this could lead to some unexpected future problems.

@KevLehman
Copy link
Contributor Author

Changed this PR to another task. Both issues will be fixed anyways as this changes the same code the other PR does.

MartinSchoeler
MartinSchoeler previously approved these changes Aug 16, 2024
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Aug 20, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 20, 2024
@kodiakhq kodiakhq bot merged commit 51f2fc2 into develop Aug 20, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/processroomabandonment-callback branch August 20, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants