-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: processRoomAbandonment
callback not processing data correctly
#33036
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 11fbb28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #33036 +/- ##
===========================================
+ Coverage 59.40% 59.44% +0.03%
===========================================
Files 2543 2544 +1
Lines 63180 63251 +71
Branches 14219 14240 +21
===========================================
+ Hits 37532 37598 +66
Misses 22933 22933
- Partials 2715 2720 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
apps/meteor/app/livechat/server/hooks/processRoomAbandonment.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest to split the 2 fixes you mentioned in 2 different PRs, since we are changing the way things are calculated, this could lead to some unexpected future problems.
Changed this PR to another task. Both issues will be fixed anyways as this changes the same code the other PR does. |
8cb3049
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-619
Steps to test or reproduce
Further comments