Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove persists from updater #33037

Merged
merged 5 commits into from
Aug 14, 2024
Merged

chore: remove persists from updater #33037

merged 5 commits into from
Aug 14, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Aug 13, 2024

following the decisions described in the adr https://adr.rocket.chat/0099
https://rocketchat.atlassian.net/browse/OPI-20

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Aug 13, 2024

⚠️ No Changeset found

Latest commit: d94ca80

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Aug 13, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.

Project coverage is 59.40%. Comparing base (c11f372) to head (d94ca80).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33037      +/-   ##
===========================================
- Coverage    59.40%   59.40%   -0.01%     
===========================================
  Files         2541     2541              
  Lines        63178    63181       +3     
  Branches     14219    14222       +3     
===========================================
- Hits         37532    37531       -1     
- Misses       22931    22935       +4     
  Partials      2715     2715              
Flag Coverage Δ
unit 76.04% <52.63%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added this to the 6.12 milestone Aug 13, 2024
@ggazzo ggazzo marked this pull request as ready for review August 13, 2024 20:10
@ggazzo ggazzo requested review from a team as code owners August 13, 2024 20:10
@ggazzo ggazzo merged commit 19824bd into develop Aug 14, 2024
49 checks passed
@ggazzo ggazzo deleted the chore/updater-model branch August 14, 2024 13:52
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants