Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add closedBy on apps-engine #33048

Merged
merged 4 commits into from
Aug 22, 2024
Merged

feat: add closedBy on apps-engine #33048

merged 4 commits into from
Aug 22, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Aug 14, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Aug 14, 2024

⚠️ No Changeset found

Latest commit: 0c5c474

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Aug 14, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@ggazzo ggazzo marked this pull request as ready for review August 14, 2024 13:58
@ggazzo ggazzo requested a review from a team as a code owner August 14, 2024 13:58
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.38%. Comparing base (9a69771) to head (0c5c474).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33048   +/-   ##
========================================
  Coverage    59.38%   59.38%           
========================================
  Files         2547     2547           
  Lines        63255    63255           
  Branches     14228    14228           
========================================
  Hits         37567    37567           
  Misses       22978    22978           
  Partials      2710     2710           
Flag Coverage Δ
unit 75.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

KevLehman
KevLehman previously approved these changes Aug 14, 2024
@ggazzo ggazzo added this to the 6.12 milestone Aug 14, 2024
ricardogarim
ricardogarim previously approved these changes Aug 15, 2024
@ggazzo ggazzo dismissed stale reviews from ricardogarim and KevLehman via 2b013df August 22, 2024 13:50
@ggazzo ggazzo requested review from a team as code owners August 22, 2024 13:50
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 22, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 22, 2024
@ggazzo ggazzo merged commit d9dd2c4 into develop Aug 22, 2024
51 checks passed
@ggazzo ggazzo deleted the feat/closed-by-apps-engine branch August 22, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants