Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apps-engine message converter cache by any obj #33053

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Aug 14, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Aug 14, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 14, 2024

⚠️ No Changeset found

Latest commit: 7f0802f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.39%. Comparing base (8162986) to head (7f0802f).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33053   +/-   ##
========================================
  Coverage    59.39%   59.39%           
========================================
  Files         2541     2541           
  Lines        63174    63174           
  Branches     14219    14219           
========================================
  Hits         37525    37525           
  Misses       22934    22934           
  Partials      2715     2715           
Flag Coverage Δ
unit 76.02% <75.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added this to the 6.12 milestone Aug 19, 2024
@ggazzo ggazzo marked this pull request as ready for review August 19, 2024 13:26
@ggazzo ggazzo requested review from a team as code owners August 19, 2024 13:26
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 19, 2024
@kodiakhq kodiakhq bot merged commit a40541b into develop Aug 19, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the feat/app-cache branch August 19, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants