Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Settings files sanitization #33057

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Aug 14, 2024

Proposed changes (including videos or screenshots)

Currently the GenericGroupPage isn't generic as it should since it has the sections inside. In order to be generic, the sections should be come from props. So this PR aims to:

1 - Transform the GenericGroupPage into a real generic settings group page;
2 - Reduce the complexity regarding the TabbedGroupPage;
3 - Remove the unnecessary AssetsGroupPage;
4 - Rename files and re-organize them improving the legibility and being easier to find

Issue(s)

Steps to test or reproduce

Further comments

SCI-73

Copy link
Contributor

dionisio-bot bot commented Aug 14, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 14, 2024

⚠️ No Changeset found

Latest commit: 82d518e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.40%. Comparing base (f882124) to head (82d518e).
Report is 20 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33057      +/-   ##
===========================================
- Coverage    59.40%   59.40%   -0.01%     
===========================================
  Files         2541     2541              
  Lines        63181    63169      -12     
  Branches     14222    14217       -5     
===========================================
- Hits         37531    37523       -8     
+ Misses       22935    22931       -4     
  Partials      2715     2715              
Flag Coverage Δ
unit 76.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review August 16, 2024 01:44
@dougfabris dougfabris requested review from a team as code owners August 16, 2024 01:44
@dougfabris dougfabris added this to the 6.12 milestone Aug 19, 2024
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Aug 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 19, 2024
@ggazzo ggazzo merged commit 5d657ee into develop Aug 19, 2024
57 checks passed
@ggazzo ggazzo deleted the chore/settings-sanitization branch August 19, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants