-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Settings files sanitization #33057
Conversation
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33057 +/- ##
===========================================
- Coverage 59.40% 59.40% -0.01%
===========================================
Files 2541 2541
Lines 63181 63169 -12
Branches 14222 14217 -5
===========================================
- Hits 37531 37523 -8
+ Misses 22935 22931 -4
Partials 2715 2715
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
Currently the
GenericGroupPage
isn't generic as it should since it has the sections inside. In order to be generic, the sections should be come from props. So this PR aims to:1 - Transform the
GenericGroupPage
into a real generic settings group page;2 - Reduce the complexity regarding the
TabbedGroupPage
;3 - Remove the unnecessary
AssetsGroupPage
;4 - Rename files and re-organize them improving the legibility and being easier to find
Issue(s)
Steps to test or reproduce
Further comments
SCI-73