Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Realtime Monitoring/Chart component to TS #33076

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Aug 16, 2024

Proposed changes (including videos or screenshots)

Refactors the <Chart /> component to Typescript and removes forwardref from it

Issue(s)

CORE-634

Copy link
Contributor

dionisio-bot bot commented Aug 16, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 16, 2024

⚠️ No Changeset found

Latest commit: 73c845f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MartinSchoeler MartinSchoeler added this to the 6.12 milestone Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.44%. Comparing base (908391a) to head (73c845f).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33076   +/-   ##
========================================
  Coverage    59.44%   59.44%           
========================================
  Files         2544     2544           
  Lines        63251    63251           
  Branches     14240    14240           
========================================
  Hits         37598    37598           
  Misses       22933    22933           
  Partials      2720     2720           
Flag Coverage Δ
unit 76.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review August 19, 2024 13:16
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner August 19, 2024 13:16
Copy link
Contributor

@csuadev csuadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Aug 20, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 20, 2024
@dougfabris dougfabris added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Aug 20, 2024
@kodiakhq kodiakhq bot merged commit a134176 into develop Aug 21, 2024
45 checks passed
@kodiakhq kodiakhq bot deleted the chart-ts-1 branch August 21, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants