Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: RealTimeMonitoringPage to TS #33115

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Conversation

MartinSchoeler
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Aug 20, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 20, 2024

⚠️ No Changeset found

Latest commit: f732717

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.33%. Comparing base (54b1f05) to head (f732717).
Report is 1 commits behind head on chart-ts-3.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           chart-ts-3   #33115   +/-   ##
===========================================
  Coverage       59.33%   59.33%           
===========================================
  Files            2548     2548           
  Lines           63321    63321           
  Branches        14248    14248           
===========================================
  Hits            37571    37571           
  Misses          23043    23043           
  Partials         2707     2707           
Flag Coverage Δ
unit 75.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review August 30, 2024 00:15
@ggazzo ggazzo requested a review from a team as a code owner August 30, 2024 00:15
@MartinSchoeler MartinSchoeler merged commit 26ee490 into chart-ts-3 Sep 2, 2024
49 checks passed
@MartinSchoeler MartinSchoeler deleted the chart-ts-4 branch September 2, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant