Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow using db watchers in localhost #33120

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

Starting from #32589 there is no way to run local but still using the "old" MongoDB change streams, with this change you'll be able to set DISABLE_DB_WATCHERS=no and have the old behavior.

The defaults haven't changed though:

  • In production it still uses MongoDB change streams by default (you should set DISABLE_DB_WATCHERS=yes to disable change streams)
  • In local environment DB watchers are disabled by default

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego added this to the 6.12 milestone Aug 21, 2024
Copy link
Contributor

dionisio-bot bot commented Aug 21, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 21, 2024

⚠️ No Changeset found

Latest commit: 335a004

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Aug 21, 2024
@KevLehman KevLehman assigned KevLehman and unassigned KevLehman Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.43%. Comparing base (2b13061) to head (335a004).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33120   +/-   ##
========================================
  Coverage    59.43%   59.43%           
========================================
  Files         2546     2546           
  Lines        63255    63257    +2     
  Branches     14235    14236    +1     
========================================
+ Hits         37594    37596    +2     
  Misses       22941    22941           
  Partials      2720     2720           
Flag Coverage Δ
unit 76.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Aug 21, 2024
@ggazzo ggazzo merged commit 2f402fd into develop Aug 21, 2024
51 checks passed
@ggazzo ggazzo deleted the chore-enable-db-watcher-local branch August 21, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants