Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: executeSetReaction receiving wrong params #33131

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

KevLehman
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

I messed up the order of the 3 string params on the call to executeSetReaction

Copy link
Contributor

dionisio-bot bot commented Aug 22, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 22, 2024

⚠️ No Changeset found

Latest commit: 167b767

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Aug 22, 2024
@KevLehman KevLehman added this to the 6.12 milestone Aug 22, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.39%. Comparing base (d9dd2c4) to head (167b767).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33131   +/-   ##
========================================
  Coverage    59.39%   59.39%           
========================================
  Files         2547     2547           
  Lines        63241    63241           
  Branches     14223    14223           
========================================
  Hits         37559    37559           
  Misses       22974    22974           
  Partials      2708     2708           
Flag Coverage Δ
unit 75.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review August 22, 2024 18:18
@KevLehman KevLehman requested a review from a team as a code owner August 22, 2024 18:18
@kodiakhq kodiakhq bot merged commit f6351e8 into develop Aug 22, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the regression/reaction-params branch August 22, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants