Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow admins to control if visitors can close omnichannel conversations #33139

Merged
merged 11 commits into from
Sep 9, 2024

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Aug 23, 2024

Proposed changes (including videos or screenshots)

Visitors have always had the ability of closing ongoing conversations. This, however, means a visitor can close a conversation before it has been served or before an automation process has finished on customer side, which can cause issues.

New setting Allow visitors to finish conversations is created with this purpose. By default, the same behavior will be kept, where visitors can close conversations. When the setting is off, visitors won't see the button to close a conversation and the API will throw an error for them. This doesn't affect agent's capabilities of closing conversations.

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-632

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Aug 23, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 23, 2024

🦋 Changeset detected

Latest commit: a18669d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/i18n Minor
@rocket.chat/livechat Minor
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/gazzodown Major
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.32%. Comparing base (06dbf72) to head (a18669d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33139   +/-   ##
========================================
  Coverage    59.32%   59.32%           
========================================
  Files         2548     2548           
  Lines        63415    63415           
  Branches     14268    14268           
========================================
  Hits         37622    37622           
  Misses       23090    23090           
  Partials      2703     2703           
Flag Coverage Δ
unit 75.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman changed the title feat: Add new setting to enable/disable visitors from closing a conversation feat: Allow admins to control if visitors can close omnichannel conversations Aug 23, 2024
packages/i18n/src/locales/en.i18n.json Outdated Show resolved Hide resolved
packages/i18n/src/locales/en.i18n.json Outdated Show resolved Hide resolved
@KevLehman KevLehman added this to the 6.13 milestone Aug 23, 2024
@KevLehman KevLehman marked this pull request as ready for review August 23, 2024 19:15
@KevLehman KevLehman requested review from a team as code owners August 23, 2024 19:15
Co-authored-by: Matheus Barbosa Silva <[email protected]>
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Sep 9, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 9, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 9, 2024
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Sep 9, 2024
@kodiakhq kodiakhq bot merged commit 7c14fd1 into develop Sep 9, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the feat/configurable-visitor-chat-closing branch September 9, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants