Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NPS passing startAt as the expiration date when creating a banner #33155

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Aug 26, 2024

Proposed changes (including videos or screenshots)

Not much, dates were being swapped. Func was expecting the expiration date but NPS service was providing the start date from the NPS payload.

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-649

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Aug 26, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: e246c3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.32%. Comparing base (cd0d500) to head (e246c3b).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33155      +/-   ##
===========================================
- Coverage    59.33%   59.32%   -0.02%     
===========================================
  Files         2548     2548              
  Lines        63363    63415      +52     
  Branches     14252    14268      +16     
===========================================
+ Hits         37598    37622      +24     
- Misses       23062    23090      +28     
  Partials      2703     2703              
Flag Coverage Δ
unit 75.10% <100.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review August 27, 2024 02:08
@KevLehman KevLehman requested a review from a team as a code owner August 27, 2024 02:08
@KevLehman KevLehman added this to the 6.13 milestone Sep 2, 2024
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Sep 6, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 6, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 6, 2024
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Sep 6, 2024
@kodiakhq kodiakhq bot merged commit e0050c3 into develop Sep 6, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the fix/nps-create-banner-passing-wrong-expire-date branch September 6, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants