chore: improve omni queue metrics query #33159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 0ed4cde The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33159 +/- ##
========================================
Coverage 59.33% 59.33%
========================================
Files 2546 2546
Lines 63242 63235 -7
Branches 14217 14214 -3
========================================
- Hits 37525 37521 -4
+ Misses 23015 23014 -1
+ Partials 2702 2700 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
sampaiodiego
force-pushed
the
improve-queue-query
branch
3 times, most recently
from
e627bd5
to
ba18fc5
Compare
ggazzo
previously approved these changes
Sep 2, 2024
KevLehman
previously approved these changes
Sep 2, 2024
sampaiodiego
force-pushed
the
improve-queue-query
branch
from
ba18fc5
to
0ed4cde
Compare
sampaiodiego
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
ggazzo
approved these changes
Sep 2, 2024
ricardogarim
approved these changes
Sep 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The results should be the same but the pipeline structure is better for consuming less memory between stages.
Although the commits don't show it, I have added a few test cases for the endpoints that uses the query. I have then ran the tests against the old query and the new query.
Issue(s)
Steps to test or reproduce
Further comments