Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Multi-step modals closing unexpectedly #33178

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Aug 28, 2024

Backport of #33158

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner August 28, 2024 17:36
@dionisio-bot dionisio-bot bot requested a review from dougfabris August 28, 2024 17:36
Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: 1c630b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot dionisio-bot bot added this to the 6.11 milestone Aug 28, 2024
Copy link
Contributor Author

dionisio-bot bot commented Aug 28, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@dionisio-bot dionisio-bot bot added backport and removed backport labels Aug 28, 2024
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Aug 28, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 28, 2024
@kodiakhq kodiakhq bot merged commit 87a59e0 into release-6.11.2 Aug 28, 2024
12 of 13 checks passed
@kodiakhq kodiakhq bot deleted the backport-6.11.2-33158 branch August 28, 2024 17:41
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.67%. Comparing base (4baf1e4) to head (1c630b5).
Report is 1 commits behind head on release-6.11.2.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.11.2   #33178      +/-   ##
==================================================
+ Coverage           55.64%   55.67%   +0.02%     
==================================================
  Files                2636     2635       -1     
  Lines               57495    57485      -10     
  Branches            11933    11934       +1     
==================================================
+ Hits                31995    32003       +8     
- Misses              22780    22796      +16     
+ Partials             2720     2686      -34     
Flag Coverage Δ
unit 71.95% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant