Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Upgrade to TypeScript 5.5 #33187

Merged
merged 1 commit into from
Sep 2, 2024
Merged

refactor: Upgrade to TypeScript 5.5 #33187

merged 1 commit into from
Sep 2, 2024

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Aug 30, 2024

Proposed changes (including videos or screenshots)

It upgrades TypeScript to 5.5.4, which introduces subtle changes in generic-types inference and required a upgrade on Typia library too.

Issue(s)

Steps to test or reproduce

Further comments

This upgrade is expected to reduce build time.

Copy link
Contributor

dionisio-bot bot commented Aug 30, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 30, 2024

⚠️ No Changeset found

Latest commit: 0ccfe91

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.33%. Comparing base (0f5a39e) to head (0ccfe91).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33187      +/-   ##
===========================================
- Coverage    59.33%   59.33%   -0.01%     
===========================================
  Files         2546     2546              
  Lines        63245    63242       -3     
  Branches     14220    14217       -3     
===========================================
- Hits         37527    37525       -2     
+ Misses       23016    23015       -1     
  Partials      2702     2702              
Flag Coverage Δ
unit 75.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan marked this pull request as ready for review August 31, 2024 19:13
@tassoevan tassoevan requested review from a team as code owners August 31, 2024 19:13
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Sep 2, 2024
@ggazzo ggazzo merged commit 377b8bb into develop Sep 2, 2024
51 checks passed
@ggazzo ggazzo deleted the bump/ts branch September 2, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants