Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show parent & team information on UI #33199

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Sep 2, 2024

Proposed changes (including videos or screenshots)

  • Updates UI to adapt to new rooms.info payload

Issue(s)

https://rocketchat.atlassian.net/browse/SIDE-156

Steps to test or reproduce

Further comments

This is separated from another PR with backend-only changes. Aim is to show the new data coming from rooms.info call into the headers (v1 & v2)

@KevLehman KevLehman requested a review from a team as a code owner September 2, 2024 18:06
Copy link
Contributor

dionisio-bot bot commented Sep 2, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 6.14.0, but it targets 6.13.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 2, 2024

🦋 Changeset detected

Latest commit: b8e5e4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.84%. Comparing base (4033974) to head (b8e5e4a).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33199      +/-   ##
===========================================
- Coverage    59.85%   59.84%   -0.01%     
===========================================
  Files         2554     2554              
  Lines        63004    63048      +44     
  Branches     14127    14133       +6     
===========================================
+ Hits         37708    37733      +25     
- Misses       22890    22906      +16     
- Partials      2406     2409       +3     
Flag Coverage Δ
unit 77.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Base automatically changed from improve-rooms-info-endpoint to develop September 5, 2024 17:04
@KevLehman KevLehman added this to the 6.13 milestone Sep 9, 2024
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33199/
on branch gh-pages at 2024-09-18 16:21 UTC

@ggazzo ggazzo modified the milestones: 6.13, 6.14 Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants