Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Upgrade Fuselage and remove unnecessary FieldError styling #33205

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

rique223
Copy link
Contributor

@rique223 rique223 commented Sep 3, 2024

Proposed changes (including videos or screenshots)

Removed the fontScale from the user creation email field error component because this style should be changed on fuselage and not on place. Also upgraded fuselage and related packages.

Before:
image

After:
image

Issue(s)

Steps to test or reproduce

Further comments

Jira task: CONN-338
Related to: #1442

Removed the fontScale from the user creation email field error component because this style should be changed on fuselage and not on place.
Copy link

changeset-bot bot commented Sep 3, 2024

⚠️ No Changeset found

Latest commit: 522021c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Sep 3, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.73%. Comparing base (cfc84ab) to head (522021c).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33205   +/-   ##
========================================
  Coverage    59.73%   59.73%           
========================================
  Files         2548     2548           
  Lines        63073    63073           
  Branches     14090    14090           
========================================
  Hits         37679    37679           
  Misses       22978    22978           
  Partials      2416     2416           
Flag Coverage Δ
unit 76.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rique223 rique223 marked this pull request as ready for review September 4, 2024 13:10
@rique223 rique223 requested a review from a team as a code owner September 4, 2024 13:10
Copy link
Contributor

@juliajforesti juliajforesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this PR should include fuselage new version with the typography changes?

@rique223 rique223 marked this pull request as draft September 4, 2024 19:26
@rique223 rique223 changed the title chore: Remove unnecessary style from email FieldError chore: Upgrade fuselage and remove unnecessary styling Sep 6, 2024
@rique223 rique223 changed the title chore: Upgrade fuselage and remove unnecessary styling chore: Upgrade fuselage and remove unnecessary FieldError styling Sep 6, 2024
@rique223 rique223 changed the title chore: Upgrade fuselage and remove unnecessary FieldError styling chore: Upgrade Fuselage and remove unnecessary FieldError styling Sep 6, 2024
@rique223 rique223 changed the title chore: Upgrade Fuselage and remove unnecessary FieldError styling refactor: Upgrade Fuselage and remove unnecessary FieldError styling Sep 6, 2024
@rique223 rique223 added this to the 6.13 milestone Sep 6, 2024
@rique223 rique223 marked this pull request as ready for review September 6, 2024 15:34
tassoevan
tassoevan previously approved these changes Sep 11, 2024
@rique223 rique223 removed the request for review from juliajforesti September 11, 2024 15:12
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Sep 11, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 11, 2024
@tassoevan tassoevan dismissed juliajforesti’s stale review September 11, 2024 21:17

requested changes addressed

Copy link
Contributor

github-actions bot commented Sep 11, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-11 21:57 UTC

@kodiakhq kodiakhq bot merged commit 18b1b99 into develop Sep 11, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the chore/remove-incongruent-style branch September 11, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants