-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Upgrade Fuselage
and remove unnecessary FieldError
styling
#33205
Conversation
Removed the fontScale from the user creation email field error component because this style should be changed on fuselage and not on place.
|
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33205 +/- ##
========================================
Coverage 59.73% 59.73%
========================================
Files 2548 2548
Lines 63073 63073
Branches 14090 14090
========================================
Hits 37679 37679
Misses 22978 22978
Partials 2416 2416
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this PR should include fuselage new version with the typography changes?
FieldError
styling
FieldError
stylingFuselage
and remove unnecessary FieldError
styling
The peer dependencies are workspace dependencies because of that I've changed them to "*"
Fuselage
and remove unnecessary FieldError
stylingFuselage
and remove unnecessary FieldError
styling
…e/remove-incongruent-style
requested changes addressed
|
Proposed changes (including videos or screenshots)
Removed the fontScale from the user creation email field error component because this style should be changed on fuselage and not on place. Also upgraded fuselage and related packages.
Before:
After:
Issue(s)
Steps to test or reproduce
Further comments
Jira task: CONN-338
Related to: #1442