Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move GenericMenu to ui-client package #33247

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Sep 10, 2024

Proposed changes (including videos or screenshots)

Moved the component GenericMenu to the @rocket.chat/ui-client package and adjusted imports accordingly. This change will allow this component to be used by packages outside apps/meteor.

Copy link
Contributor

dionisio-bot bot commented Sep 10, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 10, 2024

⚠️ No Changeset found

Latest commit: c19e70d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.76%. Comparing base (ec6f6a6) to head (c19e70d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33247      +/-   ##
===========================================
+ Coverage    59.73%   59.76%   +0.02%     
===========================================
  Files         2548     2551       +3     
  Lines        63075    63118      +43     
  Branches     14090    14116      +26     
===========================================
+ Hits         37681    37720      +39     
- Misses       22978    22982       +4     
  Partials      2416     2416              
Flag Coverage Δ
unit 76.98% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva added this to the 6.13 milestone Sep 11, 2024
@aleksandernsilva aleksandernsilva marked this pull request as ready for review September 11, 2024 12:22
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner September 11, 2024 12:22
@gabriellsh gabriellsh changed the title chore: moved GenericMenu to ui-client package chore: move GenericMenu to ui-client package Sep 11, 2024
Copy link
Contributor

github-actions bot commented Sep 12, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-12 19:24 UTC

gabriellsh
gabriellsh previously approved these changes Sep 12, 2024
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Sep 12, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 12, 2024
tassoevan
tassoevan previously approved these changes Sep 12, 2024
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 12, 2024
Copy link
Contributor

kodiakhq bot commented Sep 12, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@aleksandernsilva aleksandernsilva added the stat: ready to merge PR tested and approved waiting for merge label Sep 12, 2024
@kodiakhq kodiakhq bot merged commit 811e2cb into develop Sep 12, 2024
52 checks passed
@kodiakhq kodiakhq bot deleted the chore/ui-client-generic-menu branch September 12, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants